You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Single file changed: VariantSummaryCuration.jsx — adds fallback logic for three variant attributes that can be missing from the primary data source.
Changes reviewed:
crossReferences fallback (lines 32-35): Falls back to allele.dataProviderCrossReference when variant-level cross references are empty. The [...].filter(Boolean) guard correctly handles the case where the allele field is also missing, producing an empty array that the downstream crossReferences.length check handles properly.
nucleotideChange fallback chain (lines 50-53): Three-tier fallback: direct field → constructed from ref/var sequences → regex extraction from HGVS genomic notation. The regex /g\.\d+(?:_\d+)?(.+)$/ correctly captures the change portion of standard HGVS g. notation (e.g., A>G from g.12345A>G, del from g.12345del).
hgvsC / hgvsP fallback (lines 59-64): Falls back to mapping predictedVariantConsequences when direct fields are absent. The .filter(Boolean) strips null/undefined entries. An empty result array correctly short-circuits at the hgvsC.length / hgvsP.length render guards (lines 154, 157).
The predictedVariantConsequences extraction was correctly hoisted above its new consumers. All fallback paths handle undefined/null/empty inputs without risk of runtime errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.