Skip to content

SCRUM-5928 fix missing attributes: nucleotide change, cross references#1751

Merged
cmpich merged 3 commits intostagefrom
SCRUM-5829
Apr 14, 2026
Merged

SCRUM-5928 fix missing attributes: nucleotide change, cross references#1751
cmpich merged 3 commits intostagefrom
SCRUM-5829

Conversation

@cmpich
Copy link
Copy Markdown
Contributor

@cmpich cmpich commented Apr 14, 2026

No description provided.

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 14, 2026

Code Review

Single file changed: VariantSummaryCuration.jsx — adds fallback logic for three variant attributes that can be missing from the primary data source.

Changes reviewed:

  1. crossReferences fallback (lines 32-35): Falls back to allele.dataProviderCrossReference when variant-level cross references are empty. The [...].filter(Boolean) guard correctly handles the case where the allele field is also missing, producing an empty array that the downstream crossReferences.length check handles properly.

  2. nucleotideChange fallback chain (lines 50-53): Three-tier fallback: direct field → constructed from ref/var sequences → regex extraction from HGVS genomic notation. The regex /g\.\d+(?:_\d+)?(.+)$/ correctly captures the change portion of standard HGVS g. notation (e.g., A>G from g.12345A>G, del from g.12345del).

  3. hgvsC / hgvsP fallback (lines 59-64): Falls back to mapping predictedVariantConsequences when direct fields are absent. The .filter(Boolean) strips null/undefined entries. An empty result array correctly short-circuits at the hgvsC.length / hgvsP.length render guards (lines 154, 157).

The predictedVariantConsequences extraction was correctly hoisted above its new consumers. All fallback paths handle undefined/null/empty inputs without risk of runtime errors.

No issues found — looks good.

@cmpich cmpich enabled auto-merge April 14, 2026 14:01
@cmpich cmpich merged commit 82c30da into stage Apr 14, 2026
5 checks passed
@cmpich cmpich deleted the SCRUM-5829 branch April 14, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants