Merged
Conversation
Code ReviewChanges look correct. The PR cleanly adds the
No bugs, no performance concerns, no security issues found. |
oblodgett
requested changes
Apr 7, 2026
oblodgett
reviewed
Apr 7, 2026
Add VariantSearchResultConverter to VariantSummaryCurationIndexer so low throughput variant HGVS names are indexed and searchable.
…ments Variant indexer improvements
Member
|
@cmpich I need to get some code in to fix the filters and stuff on the allele-detail page. |
…ch results - Add crossReferences field (allele ID + gene ID) so alleles are discoverable by gene cross reference (e.g. MGI:104735, ZFIN:ZDB-GENE-*) - Populate phenotypeStatements from AlleleSummaryDocument so alleles are searchable by phenotype terms (e.g. "embryonic lethality") Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
(cherry picked from commit 0aa7b3cc2ebbce62f0289fbd9203c57c807050c5)
oblodgett
approved these changes
Apr 8, 2026
Member
oblodgett
left a comment
There was a problem hiding this comment.
I think thats all the locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.