Skip to content

SCRUM-5881 add variants as attributes on allele document#1557

Closed
cmpich wants to merge 1 commit intostagefrom
SCRUM-5881
Closed

SCRUM-5881 add variants as attributes on allele document#1557
cmpich wants to merge 1 commit intostagefrom
SCRUM-5881

Conversation

@cmpich
Copy link
Copy Markdown
Contributor

@cmpich cmpich commented Apr 7, 2026

No description provided.

@cmpich cmpich requested a review from a team as a code owner April 7, 2026 12:48
@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

Code Review: Changes look correct.

This PR cleanly adds variantHgvs as a searchable attribute on allele documents, with consistent changes across all four layers:

  • Model (AlleleSearchResultDocument): new Set<String> field
  • ES Mapping: text + keyword — consistent with similar fields like variantType
  • Converter: properly null-checks location.getHgvs() before adding, and only sets the field when non-empty
  • SearchHelper: registers both variantHgvs and variantHgvs.keyword for search

No issues found. LGTM.

add("variants.keyword");
add("variants.standardText");
add("variantHgvs");
add("variantHgvs.keyword");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be added to the variantSynonyms field and not add an extra field.

@cmpich cmpich closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants