SCRUM-5949: Fix facet sort, routing distribution, reduce BP threads#1549
Merged
SCRUM-5949: Fix facet sort, routing distribution, reduce BP threads#1549
Conversation
Replace hardcoded CATEGORY_ORDER sort with count-based sort to restore production behavior where facets appear from most to fewest results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Code Review The change looks correct. It replaces a hardcoded category display order with a simple descending sort by count ( No bugs, no performance concerns, no security issues. The removed LGTM. |
oblodgett
approved these changes
Apr 3, 2026
- Use Integer.MAX_VALUE for routing to fix empty shard problem (5 of 16 shards empty) - Reduce BP threads from shardCount*4 to shardCount*2 (32 vs 64 per species) - Add ES client identity logging to track unclosed client leak - Remove shardCount from RoutedBulkIndexer constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan