Skip to content

SCRUM-5829 make MNV variants and all other allelic variants show up i…#1530

Merged
oblodgett merged 13 commits intostagefrom
SCRUM-5829
Mar 23, 2026
Merged

SCRUM-5829 make MNV variants and all other allelic variants show up i…#1530
oblodgett merged 13 commits intostagefrom
SCRUM-5829

Conversation

@cmpich
Copy link
Copy Markdown
Contributor

@cmpich cmpich commented Mar 22, 2026

…n allele search result

@cmpich cmpich requested a review from a team as a code owner March 22, 2026 20:32
@claude
Copy link
Copy Markdown

claude bot commented Mar 22, 2026

Code Review

Changes: Adds species abbreviation to gene symbols in allele search results, populates a new variantType field from variant data, and bumps curation.version from v0.47.2 to v0.47.4.

Verdict: Changes look correct. No bugs, performance issues, or security concerns.

  • Null checks are properly handled throughout — allele.getTaxon(), SpeciesType.getTypeByNameField() result, variant type and name are all guarded before use.
  • The variant type stream pipeline correctly filters, deduplicates with distinct(), and avoids setting an empty list.
  • The allele null check at line 22 ensures the taxon access at line 61 is safe.
  • New variantType field on AlleleSearchResultDocument is additive and non-breaking.

LGTM.

@oblodgett oblodgett enabled auto-merge March 23, 2026 16:07
@oblodgett oblodgett merged commit 88e2d58 into stage Mar 23, 2026
5 checks passed
@oblodgett oblodgett deleted the SCRUM-5829 branch March 23, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants