Skip to content

SCRUM-5935: Add audit columns and expandable synonyms editor#2676

Merged
VarunReddy1111 merged 1 commit intoalphafrom
SCRUM-5935
Apr 15, 2026
Merged

SCRUM-5935: Add audit columns and expandable synonyms editor#2676
VarunReddy1111 merged 1 commit intoalphafrom
SCRUM-5935

Conversation

@VarunReddy1111
Copy link
Copy Markdown
Contributor

Summary

  • Add Date Updated and Updated By columns to both Resource Descriptors and Resource Descriptor Pages tables (read-only, sortable, filterable)
  • Replace single-line StringListEditor with a new StringListTextAreaEditor for synonyms editing — uses an auto-resizing textarea (5 rows default) to make it easier to read and edit entries with many synonyms (e.g., SNOMED)

Test plan

  • Navigate to #/resourcedescriptors — verify Date Updated and Updated By columns appear
  • Navigate to #/resourcedescriptorpages — verify Date Updated and Updated By columns appear
  • Edit a Resource Descriptor row — verify synonyms field shows a multi-line textarea instead of a single-line input
  • Check SNOMED prefix synonyms — verify all synonyms are readable without excessive horizontal scrolling
  • Verify the textarea auto-resizes as content grows

🤖 Generated with Claude Code

Add Date Updated and Updated By columns to both Resource Descriptors
and Resource Descriptor Pages tables. Replace single-line StringListEditor
with a new StringListTextAreaEditor for synonyms editing, using an
auto-resizing textarea to make it easier to read and edit entries with
many synonyms (e.g., SNOMED).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@VarunReddy1111 VarunReddy1111 requested a review from a team as a code owner April 15, 2026 20:02
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 15, 2026

Review

The changes look correct. A few observations:

Audit columns (Updated By / Date Updated): Both new column definitions in ResourceDescriptorsTable and ResourceDescriptorPagesTable exactly match the established pattern used across many other tables (ControlledVocabulary, Genes, Alleles, etc.). Filter configs exist and are correct.

StringListTextAreaEditor: This is a clean extraction from StringListEditor — same split/trim/filter logic, swapping InputText for InputTextarea with autoResize. The old StringListEditor remains in use by SpeciesTable, so nothing is orphaned.

No bugs, security issues, or performance concerns. LGTM.

@VarunReddy1111 VarunReddy1111 merged commit d6d7db6 into alpha Apr 15, 2026
11 checks passed
@VarunReddy1111 VarunReddy1111 deleted the SCRUM-5935 branch April 15, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants