Skip to content

Mergeback release v0.48.2 to alpha#2675

Merged
devopsagr merged 2 commits intoalphafrom
gh-actions-mergeback-v0.48.2-alpha
Apr 15, 2026
Merged

Mergeback release v0.48.2 to alpha#2675
devopsagr merged 2 commits intoalphafrom
gh-actions-mergeback-v0.48.2-alpha

Conversation

@devopsagr
Copy link
Copy Markdown
Contributor

Autogenerated through GH-actions.

cmpich and others added 2 commits April 15, 2026 14:20
* SCRUM-5952 index constructID into AlleleSearch document

* Add json view to Variant object
@devopsagr devopsagr requested a review from a team as a code owner April 15, 2026 14:21
@devopsagr devopsagr enabled auto-merge April 15, 2026 14:21
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 15, 2026

Review: Mergeback release v0.48.2 to alpha

Changes reviewed: AlleleDAO.java, Variant.java

Summary

Three targeted enhancements to allele summary data:

  1. Genome assembly added to variant genomic locations — Two new LEFT JOINs (genomeassemblybiologicalentity) to populate GenomeAssembly.primaryExternalId on AssemblyComponent. Both joins are PK lookups with indexed FK (assemblycomponent_genomeassembly_index). Minimal performance impact.

  2. HGVS nomenclature added to predicted variant consequenceshgvsCodingNomenclature and hgvsProteinNomenclature selected from the already-joined predictedvariantconsequence table. No new joins needed.

  3. Construct ID fallback to modinternalidCOALESCE(r.primaryexternalid, r.modinternalid) ensures constructs lacking a primaryexternalid are still included. Both columns are indexed on reagent.

  4. Variant references exposed in AlleleSummaryDocument viewCurationView.AlleleSummaryDocument.class added to @JsonView on Variant.references.

Verification

  • Confirmed all referenced columns and tables exist in production schema (genomeassembly, biologicalentity.primaryexternalid, predictedvariantconsequence.hgvscodingnomenclature, predictedvariantconsequence.hgvsproteinnomenclature, reagent.modinternalid)
  • Confirmed index coverage on join paths (genomeassembly_pkey, assemblycomponent_genomeassembly_index, biologicalentity PK)
  • Verified SELECT column indices: row[26]=genome_assembly, row[27]=hgvs_coding, row[28]=hgvs_protein — all correctly mapped in the result processing code

LGTM — no correctness, performance, or security concerns.

@devopsagr devopsagr merged commit cecc618 into alpha Apr 15, 2026
11 checks passed
@devopsagr devopsagr deleted the gh-actions-mergeback-v0.48.2-alpha branch April 15, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants