Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of what I am thinking:
remove doubles, and half step enharmonics like E# and Fb etc... no one cares.... probably
convert the incoming chord root into an integer
do math
convert is back to a note name and chose enharmonic base on a flat key array
for the most part, this takes care of things... by if you transpose into a weird key you could end up with an Fm7 chord in the key of Gb... but I don't think that's a big deal.
The diff is really strange, so you may want to merge this into a branch in your repo to better see how the code flows. I did leave it hooked up to your processChord method.
Overall... I'm blown away by your first attempt. Great job!