Skip to content

Comments

Type definitions: Symbol#32

Draft
carolinepaulic wants to merge 2 commits intomainfrom
cp/28339-subtask_model-definitions-symbol
Draft

Type definitions: Symbol#32
carolinepaulic wants to merge 2 commits intomainfrom
cp/28339-subtask_model-definitions-symbol

Conversation

@carolinepaulic
Copy link
Contributor

DRAFT: Don't merge until #26 has been merged.

Description

This covers the Symbol subtask of https://github.com/allenai/scholar/issues/28339

Changes in this PR:

  • New types for Symbol and Reference (reference to another object/entity that has an ID)

Testing Plan

  • Ran all unit tests

@carolinepaulic carolinepaulic removed the request for review from smitar September 29, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant