Skip to content

Comments

Type definitions: Mention, SymbolData, and PaperData#27

Draft
carolinepaulic wants to merge 2 commits intomainfrom
cp/28339-subtask_model-definitions-mentions
Draft

Type definitions: Mention, SymbolData, and PaperData#27
carolinepaulic wants to merge 2 commits intomainfrom
cp/28339-subtask_model-definitions-mentions

Conversation

@carolinepaulic
Copy link
Contributor

DRAFT: Don't merge until #26 has been merged.

Description

This covers the Mentions subtask of https://github.com/allenai/scholar/issues/28339

Changes in this PR:

  • New types for Mention, SymbolData, and PaperData based on example API response

Testing Plan

  • Ran all unit tests

@carolinepaulic carolinepaulic changed the base branch from cp/28339-subtask_model-definitions-entity-bounding-box to main September 1, 2021 02:38
@carolinepaulic carolinepaulic changed the title Added type definition for Mention, SymbolData, and PaperData Type definitions: Mention, SymbolData, and PaperData Sep 1, 2021
@smitar smitar removed their request for review November 16, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant