create priority queue for loading page objectURLs#201
Open
ericmarsh995 wants to merge 4 commits intomainfrom
Open
create priority queue for loading page objectURLs#201ericmarsh995 wants to merge 4 commits intomainfrom
ericmarsh995 wants to merge 4 commits intomainfrom
Conversation
huytr1995
reviewed
Oct 11, 2022
huytr1995
reviewed
Oct 11, 2022
huytr1995
reviewed
Oct 11, 2022
| return; | ||
| } | ||
|
|
||
| const visiblePagesNeighbors = [ |
Contributor
There was a problem hiding this comment.
@ericmarsh995 i would love to abstract this line from 166 - 171 into maybe a class itself where we can unit test it correctly.
huytr1995
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates a priority queue for loading objectURLs for all pages. Previously, we only loaded an objectURL once it was visible in the user viewport. Now, we will load all objectURLs from the start, one at a time. They will be loaded in this order: 1. visible pages 2. neighboring pages to the visible pages 3. every other page
Reviewer Instructions
Testing Plan
Output / Screenshots
NOTE: the console.logs are only apart of the demo video, they havent been committed
Before
Screen.Recording.2022-10-11.at.11.12.34.AM.mov
After
Screen.Recording.2022-10-11.at.11.07.26.AM.mov
A11y
N/A