-
Notifications
You must be signed in to change notification settings - Fork 491
Add NVIDIA H200 GPU support #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support for NVIDIA H200 with 989 TFLOPS, 141GB HBM3e memory, and 4.8 TB/s memory bandwidth.
Summary of ChangesHello @hamishivi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system's hardware compatibility by integrating support for the NVIDIA H200 GPU. By adding its detailed specifications to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds support for the NVIDIA H200 GPU by including its specifications in the GPU_SPECS dictionary. The change is straightforward and the values are accurate. I've included one comment regarding the dictionary's structure, which could be improved for better long-term maintainability and to prevent potential future bugs.
| "a100": {"flops": 312e12, "memory_size": 80e9, "memory_bandwidth": 2.0e12}, # 2.0 TB/s HBM2e (80GB variant) | ||
| "b200": {"flops": 2250e12, "memory_size": 192e9, "memory_bandwidth": 8e12}, # 8 TB/s HBM3e | ||
| "h100": {"flops": 990e12, "memory_size": 80e9, "memory_bandwidth": 3.35e12}, # 3.35 TB/s HBM3 | ||
| "h200": {"flops": 989e12, "memory_size": 141e9, "memory_bandwidth": 4.8e12}, # 4.8 TB/s HBM3e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specs for H200 are correct. However, the current implementation of get_device_name relies on the iteration order of the GPU_SPECS dictionary to find the correct GPU. This is fragile and can lead to bugs. For example, if a device name could match multiple keys (e.g., "pro 6000" and "6000"), the first one encountered is used.
While your placement is logical, to make this more robust for the future, we should consider modifying get_device_name to find the longest matching key. This would make the dictionary order-independent and prevent future errors when new GPUs are added.
Summary
GPU_SPECSdictionary inutils.pyUW compute uses h200, so this is needed for that.