Fix #433 Prevent per-page hangs & avoid killing job on maxbackoff#438
Open
akshan-main wants to merge 1 commit intoallenai:mainfrom
Open
Fix #433 Prevent per-page hangs & avoid killing job on maxbackoff#438akshan-main wants to merge 1 commit intoallenai:mainfrom
akshan-main wants to merge 1 commit intoallenai:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #433
Changes proposed in this pull request:
apost()now takes atimeout_sparam and wraps the entire network path inasyncio.timeout(), so a stalled server cant block foreverNoneinstead ofsys.exit(1)- the existing fallback path (make_fallback_result) handles it from there, so the rest of the PDF still gets processed--request_timeout_sCLI flag (default 120s) to control per-request timeoutBefore submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.