Added i) directory support, ii) FP rate args, iii) No-Save option#11
Added i) directory support, ii) FP rate args, iii) No-Save option#11revbucket wants to merge 5 commits intoallenai:mainfrom
Conversation
|
Oh and some more notes about point 4: |
dirkgr
left a comment
There was a problem hiding this comment.
What happens with the progress bar if the output of bff is piped into a file? Or the terminal is in a weird state?
This is why I generally prefer sticking to writing to stdout and stderr, one line at a time, and that's all. It causes the least amount of trouble in unexpected settings.
dirkgr
left a comment
There was a problem hiding this comment.
I have one suggestion. If that's too hard, let's ship it like this.
src/main.rs
Outdated
| threadpool.execute(move || { | ||
| if args.no_progress { | ||
| println!("Processing {input:?}..."); | ||
|
|
There was a problem hiding this comment.
😅
Yes will fix this before shipping
src/main.rs
Outdated
| &pbar, | ||
| args.no_progress, |
There was a problem hiding this comment.
Can Arc pointers be null? Then you could save a parameter and pass in null here instead.
There was a problem hiding this comment.
Yes...? Pretty sure we can wrap with an option and then we don't have to pass the second parameter
… to describe some new features
Several changes to main.rs:
wimbd).json*.gzfiles). Same aswimbd