add s2aff-rust to project dependencies, update s2aff version to 0.202#33
Open
atalyaalon wants to merge 11 commits intomainfrom
Open
add s2aff-rust to project dependencies, update s2aff version to 0.202#33atalyaalon wants to merge 11 commits intomainfrom
atalyaalon wants to merge 11 commits intomainfrom
Conversation
atalyaalon
changed the title
atalyaalon
changed the title
atalyaalon
force-pushed
the
add-rust-upgrade-version-0.2.1
branch
3 times, most recently
from
480046a to
9abcb63
Compare
When no stage2_candidates are found, the code was passing empty strings instead of empty lists for main/child/address fields, causing a "value is not a valid list" error. Also added missing display_name field and bumped version to 0.201. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix edge case where parse_ner_prediction could return strings instead of lists when NER produces no valid tags, causing Pydantic validation errors in the TIMO interface. Added type guards before return statement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
atalyaalon
changed the title
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
atalyaalon
force-pushed
the
add-rust-upgrade-version-0.2.1
branch
3 times, most recently
from
7098195 to
ca7a917
Compare
Production builds failed when running ROR Update in TeamCity with: - "build backend is missing the 'build_editable' hook" - "ModuleNotFoundError: No module named 'torch'" when running update_ror.py Root cause: update_ror.py imported from s2aff package before dependencies installed Minimal fix: - Add minimal setup.py for backwards compatibility with editable installs - Separate update_ror.py from s2aff by inlining S3 utilities - Add bidirectional comments documenting the intentional duplication 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
atalyaalon
force-pushed
the
add-rust-upgrade-version-0.2.1
branch
6 times, most recently
from
b020707 to
28809b9
Compare
- Build s2aff_rust from source before installing dependencies - Use .venv directly instead of uv run to avoid dependency re-resolution - Add setuptools dependency (required by hyperopt) - Handle Windows/Linux path differences for pytest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
atalyaalon
force-pushed
the
add-rust-upgrade-version-0.2.1
branch
from
28809b9 to
b68d1c4
Compare
atalyaalon
force-pushed
the
add-rust-upgrade-version-0.2.1
branch
from
7dd2962 to
bbff94d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was used for deployment to s2pypi