[Feature] add tensorbard support to the training framework #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
requested changes
May 15, 2025
Member
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
How does this deal with the additional dependency? What happens when you don't have tensorboard installed?
global variable per advice from @dirkgr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was using the olmo framework to learn pretraining on LLM and I found that it only support wandb as output for training metrics. In my training environment, the connection to wandb is not as stable, and I switched to tensorboard for local logging. It works quite well. Thus I am creating this pull request to share this modification.