Updated memmap_dtype to automatically choose based on vocab size #795
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
requested changes
Feb 13, 2025
Member
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
Sorry, I think you misunderstood. What we want is, set the dtype based on the vocab size. If the vocab size is > 2**16, then the dtype has to be uint32. If it's smaller, it has to be uint16.
aman-17
changed the title
dirkgr
requested changes
Mar 13, 2025
Member
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
The changelog is no longer accurate.
But my main question is, what happens when someone overrides the setting? Is that possible? It should be.
There is still data_config.effective_memmap_dtype. Where does that come from? Do we have to respect if it's set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
memmap_dtypeto uint32 for compatibility with OLMo-2-1124.Added links to the Discord and Playground in the readme.
Minor improvements in readme.