Skip to content

update mean reduction zloss to ignore labels == ignore_index #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonkrone wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update mean reduction zloss to ignore labels == ignore_index #760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b8109e
update mean reduction zloss to ignore labels == ignore_index vs. sett…
jasonkrone Dec 4, 2024
d25c814
Merge branch 'main' into zloss-mean-reduction-fix
dirkgr Feb 4, 2025
32d1ec6
Merge branch 'main' into zloss-mean-reduction-fix
dirkgr May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion olmo/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ def cross_entropy_loss(

z_squared = logits.logsumexp(-1).pow(2)
if reduction == "mean":
z_squared = (z_squared * (labels != ignore_index)).mean()
mask = labels != ignore_index
z_squared = (z_squared * mask).sum() / mask.sum()
elif reduction == "sum":
z_squared = (z_squared * (labels != ignore_index)).sum()

Expand Down