Skip to content

refactor(chart): accessibility, stable keys, and depth reduction#341

Draft
Copilot wants to merge 19 commits intodevelopfrom
copilot/optimize-chart-library
Draft

refactor(chart): accessibility, stable keys, and depth reduction#341
Copilot wants to merge 19 commits intodevelopfrom
copilot/optimize-chart-library

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

  • packages/client/src/widgets/home/ui/MainBanner.tsx: spring-banner-min.png 이미지에 width={740} height={788} 속성 추가 (CLS 방지)
    • 실제 이미지 크기 740×788px 기반
    • 브라우저가 이미지 로드 전 aspect-ratio(740:788)를 계산하여 공간 미리 확보
    • CSS width(w-[320px] lg:w-[370px])는 유지, height는 브라우저가 aspect-ratio로 자동 계산
  • packages/client/src/shared/ui/Image.tsx: width/height는 이미 React.ImgHTMLAttributes로 지원됨 (변경 불필요)
Original prompt

react chart 2 와, chart js 가 너무 무거워서, 이걸 우리가 필요한 것 만 따로 라이브러리 화 하려고 해. 최종적인 목표는 chart library 를 우리것으로 만들고, 최종 번들의 크기를 최적화 하는게 목표야.
먼저 client package 에서 react chart 2와 chart js 중에 어떤 기능을 쓰고 있는지 알아봐주고 먼저 그걸 정리해줘.
그 뒤에 사용하는 차트 항목이 모두 구현되도록 라이브러리화 해주고, 그걸 현재 사용하고 있는 react chart 2 나 chart js 부분을 대체해주면 돼.
최종적으로 확인했을 때 react-chart-2 나 chart-js 가 없어져야 하고, 빌드했을 때 오류가 나지 않아야 해.

최종적으로 PR을 생성하면, 설명은 한국어로 써줘.


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: hyunwoo0081 <76638365+hyunwoo0081@users.noreply.github.com>
Copilot AI changed the title [WIP] Chart library 최적화 및 통합 구현 chore: replace react-chartjs-2/chart.js with lightweight custom SVG chart library Mar 20, 2026
Copilot AI requested a review from hyunwoo0081 March 20, 2026 13:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

🚀 Preview Deployment

This preview is automatically updated on each push.

… comparison

Co-authored-by: hyunwoo0081 <76638365+hyunwoo0081@users.noreply.github.com>
Agent-Logs-Url: https://github.com/allcll/allcll-frontend/sessions/10d1c785-dec8-4385-93f9-2227e6cbe889
Copilot AI changed the title chore: replace react-chartjs-2/chart.js with lightweight custom SVG chart library feat: chart.js/react-chartjs-2 제거 + 커스텀 SVG 차트 라이브러리 도입 + uplot/visx 번들 크기 POC Mar 21, 2026
Copilot AI and others added 2 commits March 21, 2026 09:36
Copilot AI changed the title feat: chart.js/react-chartjs-2 제거 + 커스텀 SVG 차트 라이브러리 도입 + uplot/visx 번들 크기 POC feat: replace @allcll/chart with visx in client — bundle size POC Mar 21, 2026
Copilot AI and others added 2 commits March 21, 2026 11:25
Copilot AI changed the title feat: replace @allcll/chart with visx in client — bundle size POC refactor(@allcll/chart): extract shared internals, memoize SVG computations, improve maintainability Mar 21, 2026
…ayout fixes

Co-authored-by: hyunwoo0081 <76638365+hyunwoo0081@users.noreply.github.com>
Agent-Logs-Url: https://github.com/allcll/allcll-frontend/sessions/50c3a544-1335-4bef-b126-dce519f5a67d
Copilot AI changed the title refactor(@allcll/chart): extract shared internals, memoize SVG computations, improve maintainability feat(@allcll/chart): entry animations, dark tooltip, legend toggle, RadarChart overflow & MixedChart layout fixes Mar 21, 2026
…arChart overflow fix

Co-authored-by: hyunwoo0081 <76638365+hyunwoo0081@users.noreply.github.com>
Agent-Logs-Url: https://github.com/allcll/allcll-frontend/sessions/2ca75e12-45e8-44e0-be77-5fc7ab1b74a4
Copilot AI changed the title feat(@allcll/chart): entry animations, dark tooltip, legend toggle, RadarChart overflow & MixedChart layout fixes feat(@allcll/chart): value-based entry/update animations + RadarChart overflow fix Mar 22, 2026
Copilot AI changed the title feat(@allcll/chart): value-based entry/update animations + RadarChart overflow fix fix(DoughnutChart): value-based chart animations and full-circle arc rendering bug Mar 23, 2026
Copilot AI changed the title fix(DoughnutChart): value-based chart animations and full-circle arc rendering bug refactor(chart): accessibility, stable keys, and depth reduction Mar 24, 2026
Copilot stopped work on behalf of hyunwoo0081 due to an error March 25, 2026 15:43
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants