Conversation
[TSK-56-150] 간헐적 로그인 불가 문제
[TSK-69] 어드민 공지사항 관리 CRUD 기능 구현
[TSK-56-151] 고전 독서 영역 별 인증 권수 만족 시, 인증 여부 보정 로직 구현
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb1ed29d92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| try { | ||
| toscAuthService.loginTosc(client, loginRequest); | ||
| } catch (Exception exception) { | ||
| toscLoginFailed = true; |
There was a problem hiding this comment.
toscLoginFailed when TOSC auth actually fails
LoginResult.toscLoginFailed is only set in this catch, but ToscAuthService.loginTosc now handles HTTP errors, timeouts, parsing errors, and even success=false responses by logging and returning normally. That means these common failure paths never reach this block, so the API reports toscLoginFailed=false even when TOSC login/sync failed, and clients cannot surface or react to stale TOSC state.
Useful? React with 👍 / 👎.
3 participants
작업 내용
고민 지점과 리뷰 포인트