Open
Conversation
alkc
requested changes
Feb 23, 2024
Owner
alkc
left a comment
alkc
left a comment
There was a problem hiding this comment.
Thanks for submitting a PR to my obscure practice repo!
Found one detail that needs correcting before the page limit selector works flawlessly, otherwise it looks good!
Co-authored-by: Alexander Koc <alkc@users.noreply.github.com>
78wesley
commented
Feb 27, 2024
Author
78wesley
left a comment
78wesley
left a comment
There was a problem hiding this comment.
Removed form submission it gave a proxy error when pressing enter in the search field. Also updated hx-trigger at the search input to prevent spamming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated HTMX to 1.9.10 and fixed limit at the pagination that didn't work.
I tried to fix the issue to reset the page selection to 1 if limit has change. I couldn't do it with jinja so I did it with javascript.... I didn't do it with python because is a visual issue not a request issue.