Skip to content

fix: improve credential handling in session initialization #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitt-liang merged 1 commit into from
Oct 24, 2025
Merged

fix: improve credential handling in session initialization #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pai/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,13 @@ def _get_default_credential_client() -> Optional[CredentialClient]:
try:
# Initialize the credential client with default credential chain.
# see: https://help.aliyun.com/zh/sdk/developer-reference/v2-manage-python-access-credentials#3ca299f04bw3c
return CredentialClient()
except CredentialException:
client = CredentialClient()
client.get_credential()
return client
except Exception as e:
logger.debug(
"Not found credential from default credential provider chain: %s", e
)
return

@staticmethod
Expand Down
18 changes: 12 additions & 6 deletions pai/toolkit/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,14 @@

def _get_default_credential_client() -> Optional[CredentialClient]:
try:
return CredentialClient()
except CredentialException:
logger.debug("Not found credential from default credential provider chain.")
client = CredentialClient()
client.get_credential()
return client
except Exception as e:
logger.info(
"Not found credential from default credential provider chain: %s", e
)
return None


class CredentialProviderType(Enum):
Expand Down Expand Up @@ -216,9 +221,10 @@
)
)

access_key_id = credential_client.get_access_key_id()
access_key_secret = credential_client.get_access_key_secret()
security_token = credential_client.get_security_token()
credential = credential_client.get_credential()
access_key_id = credential.get_access_key_id()
access_key_secret = credential.get_access_key_secret()
security_token = credential.get_security_token()

print_highlight(f"AccessKeyId: {access_key_id}")
print_highlight(f"AccessKeySecret: { mask_secret(access_key_secret)}")
Expand All @@ -233,7 +239,7 @@

# Write input credential to default credential config file.
if credential_config:
raw_config = CREDENTIAL_INI_TEMPLATE.format(

Check failure

Code scanning / CodeQL

Clear-text storage of sensitive information High

This expression stores
sensitive data (secret)
Loading
as clear text.
access_key_id=access_key_id,
access_key_secret=access_key_secret,
)
Expand Down
Loading