Skip to content

fix: fix estmiator initialize #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitt-liang merged 2 commits into from
Mar 31, 2025
Merged

fix: fix estmiator initialize #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11a7404
fix estmiator init
pitt-liang Feb 19, 2025
fa6da93
fix estimator initialize from model
pitt-liang Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pai/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,7 @@ def __init__(
experiment_config=experiment_config,
resource_id=resource_id,
session=session,
**kwargs,
)

def training_image_uri(self) -> str:
Expand Down
6 changes: 4 additions & 2 deletions pai/model/_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,8 +2124,8 @@ def get_estimator(
ts.scheduler.max_running_time_in_seconds if ts.scheduler else None
)

resource_id = kwargs.get("resource_id")
instance_spec = kwargs.get("instance_spec")
resource_id = kwargs.pop("resource_id", None)
instance_spec = kwargs.pop("instance_spec", None)
compute_resource = ts.compute_resource
if resource_id:
if instance_type:
Expand All @@ -2146,6 +2146,7 @@ def get_estimator(
)
else:
if instance_spec:
instance_spec = None
logger.warning(
"The instance spec is ignored when resource_id is not provided."
)
Expand Down Expand Up @@ -2182,6 +2183,7 @@ def get_estimator(
instance_type=instance_type,
instance_count=instance_count,
instance_spec=instance_spec,
resource_id=resource_id,
output_path=output_path,
labels=labels,
**kwargs,
Expand Down