Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Simple_Logging library by making spinners customizable. Previously, spinners were hardcoded with two variants (ASCII and Unicode). Now users can choose from multiple predefined spinners or provide their own custom spinner animations.
Changes:
- Added a new
Simple_Logging.Spinnerschild package with 8 predefined spinner definitions (Classic, Braille_6, Braille_8, Clocks, Halves, Moon, Quarters, Squares, Triangles) - Refactored the
Activityfunction to accept a customizableSpinnerparameter, allowing per-activity spinner selection - Moved spinner-related state from global variables into the
Ongoingrecord structure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/simple_logging.ads | Added Any_Spinner type, Default_Spinner function, and new Spinner parameter to Activity function; restructured Ongoing record to include per-instance spinner state |
| src/simple_logging.adb | Removed hardcoded spinner arrays; implemented spinner selection logic in Activity; refactored Build_Status_Line to use instance-specific spinners |
| src/simple_logging-spinners.ads | New child package providing 8 predefined spinner definitions for ASCII and Unicode environments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.