Skip to content

Conversation

@mosteo
Copy link
Member

@mosteo mosteo commented Jan 17, 2026

No description provided.

@mosteo mosteo marked this pull request as ready for review January 18, 2026 08:05
Copilot AI review requested due to automatic review settings January 18, 2026 08:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a grouped Options record type to replace individual Boolean parameters for parsing and output configuration across the semantic versioning library. This refactoring improves API ergonomics by consolidating three Boolean options (Unicode, Word_Operators, and Implicit_Equal) into a single structured parameter.

Changes:

  • Introduced an Options record type with three Boolean fields to control Unicode operators, word operators, and implicit equals behavior
  • Updated all parsing and output functions in both Basic and Extended modules to use the new Options parameter instead of individual Boolean parameters
  • Added comprehensive test coverage for the new Options functionality, including tests for all three options individually and in combination

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/semantic_versioning-basic.ads Defines the new Options record type with default values and updates function signatures to use Opts parameter
src/semantic_versioning-basic.adb Updates implementation to use Opts.Unicode, Opts.Implicit_Equal fields instead of individual parameters
src/semantic_versioning-extended.ads Updates Extended module function signatures to accept Options parameter
src/semantic_versioning-extended.adb Implements word operator validation using Opts.Word_Operators and propagates Options throughout parsing
tests/src/semver_tests-options.adb Comprehensive test suite covering Unicode, Word_Operators, and Implicit_Equal options individually and in combination
tests/common/semver_tests.ads Adds UTF-8 encoding helper function for Unicode tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mosteo and others added 2 commits January 18, 2026 09:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mosteo mosteo merged commit a3e4652 into master Jan 18, 2026
5 checks passed
@mosteo mosteo deleted the feat/grouped-options branch January 18, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants