feat: Allow '¬' for negation in Unicode mode#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the '¬' (logical negation symbol) as an alternative to '!' and 'not' for negation operations in semantic version expressions. The change implements the feature requested in issue #13.
Changes:
- Extended the grammar to include '¬' as a valid negation operator
- Modified the lexer to recognize '¬' as a Negation token
- Updated the Match_Token procedure to handle '¬' appropriately
- Added basic test coverage for the new symbol
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| grammar.txt | Updated the NEG production rule to include '¬' as a valid negation operator |
| src/semantic_versioning-extended.adb | Added '¬' to the case statement for token recognition and Match_Token handling |
| tests/src/semver_tests-negation.adb | Added a basic test case verifying '¬' works for negation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mosteo
force-pushed
the
feat/neg-symbol
branch
from
2cdab75 to
540b7a8
Compare
mosteo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13