Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for word operators (and, or, not) as more readable alternatives to the existing symbolic operators (&, |, !) in semantic version expressions. The implementation includes case-insensitive keyword recognition, proper word boundary detection, and comprehensive test coverage.
Changes:
- Added keyword detection for
and,or, andnotoperators with case-insensitive matching and word boundary validation - Updated error messages to reference word operators for better user experience
- Added comprehensive test coverage for word operators, precedence rules, and mixed operator usage
- Updated grammar documentation to reflect the new operator alternatives
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/semantic_versioning-extended.adb | Implements Is_Keyword function for keyword detection and Match_Token procedure to handle both word and symbol operators |
| tests/src/semver_tests-word_operators.adb | New test file covering basic word operator functionality, case insensitivity, and error cases |
| tests/src/semver_tests-precedences.adb | New test file verifying operator precedence and mixing word/symbol operators |
| tests/src/semver_tests-extended_expressions.adb | Adds integration tests for word operators in complex expressions |
| grammar.txt | Updates grammar documentation to show word operators as alternatives to symbols |
| .github/workflows/test.yml | Updates CI runners to newer versions (unrelated infrastructure improvement) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16