Add configurable output stream to AnsiLog to avoid hardcoded System.out#3128
Merged
hengyunabc merged 2 commits intomasterfrom Jan 9, 2026
Merged
Add configurable output stream to AnsiLog to avoid hardcoded System.out#3128hengyunabc merged 2 commits intomasterfrom
hengyunabc merged 2 commits intomasterfrom
Conversation
|
|
Co-authored-by: hengyunabc <1683936+hengyunabc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add configurable out field to AnsiLog
Add configurable output stream to AnsiLog to avoid hardcoded System.out
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnsiLog currently hardcodes
System.out, which pollutes host stdout for embedded agents. This adds a configurable output stream while keeping default behavior.PrintStream outwith setters/getters to override the log sink; defaults toSystem.out.Original prompt
This section details on the original issue you should resolve
<issue_title>Add a configurable
outfield toAnsiLog, similar to the existingLEVELfield</issue_title><issue_description>- [ ] 我已经在 issues 里搜索,没有重复的issue。
环境信息
When Arthas is embedded in other applications (e.g., OpenTelemetry Java Agent,
Spring Boot applications), AnsiLog outputs directly to System.out, which:
The official
AgentBootstrapalready uses a configurablePrintStreampattern,but
AnsiLogstill hardcodesSystem.out.Solution
Add a configurable
outfield toAnsiLog, similar to the existingLEVELfield:System.out(backward compatible)AnsiLog.out(PrintStream)/AnsiLog.out()volatile期望的结果