Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d45c49734f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e35ecba27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfeef4cca0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const timeoutSeconds = | ||
| opts.timeoutSeconds === null | ||
| ? null | ||
| : Math.floor(opts.timeoutSeconds ?? DEFAULT_TIMEOUT_SECONDS); |
There was a problem hiding this comment.
Reject non-finite timeout values before request encoding
opts.timeoutSeconds is passed through Math.floor without validating that it is a finite number. In JavaScript, Math.floor(NaN)/Math.floor(Infinity) stays non-finite, and JSON serialization turns those values into null; after this change, timeout: null is treated as manual-cleanup mode. That means a caller with a bad timeout parse can silently create non-expiring sandboxes instead of receiving an input error, which is a resource-leak risk.
Useful? React with 👍 / 👎.
Summary
nulltimeoutas non-expiring sandbox creation.expiresAtand explicit cleanup semantics.Testing
Breaking Changes
Impact:
expiresAt = nullfor manual-cleanup sandboxes.expiresAtis always a timestamp may fail when theycreate,get, orlistmanual-cleanup sandboxes.Migration path:
timeoutomitted ornull.Checklist