Open
Conversation
Collaborator
|
LGTM! Thanks a lot! |
chenbohua3
approved these changes
Nov 23, 2022
zzpmiracle
changed the title
bddppq
reviewed
Feb 10, 2023
| runtime_base_image: nvidia/cuda:11.3.0-cudnn8-devel-ubuntu20.04 | ||
| extra_build_args: --build-arg PYTHON_VERSION=PYTHON3.8 --build-arg ENABLE_FIND_FASTEST_APT_SOURCE=OFF | ||
| extra_envs: -e TORCH_BLADE_BUILD_TENSORRT_STATIC=ON | ||
| extra_envs: -e TORCH_BLADE_BUILD_TENSORRT_STATIC=OFF |
Collaborator
Author
There was a problem hiding this comment.
Just for product test. Our product better to provide static linked version, to reduce user's envoiroment request. But we met some compile error for TRT8.5 like (.text._ZN5torch5blade21GetTorchMlirWhiteListEv+0x17): relocation truncated to fit: R_X86_64_PC32 against .bss._ZGVZN5torch5blade21GetTorchMlirWhiteListEvE10white_list' in all static link build. This used to occur in torch1.12+cu113 only, so change this to fix this remaining problem. I'm testing some compiler flag locally such as -fPIC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.