-
Notifications
You must be signed in to change notification settings - Fork 6
refactoring into modules and season selector #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rhys18751996
wants to merge
39
commits into
algernhon:main
Choose a base branch
from
Rhys18751996:feature/series-selector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactoring into modules and season selector #16
Rhys18751996
wants to merge
39
commits into
algernhon:main
from
Rhys18751996:feature/series-selector
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a season dropdown to filter available characters and markers by season - Integrated SeasonController to manage current season state - Updated SliderController to dynamically adjust episode range based on selected season - Refactored MarkersController to allow adding markers per season - Updated main.js to initialize SeasonController and expose global seasonChange handler - Ensures only relevant characters, paths, and markers are displayed per season
- Updated MarkersController.js to filter markers by currently selected season and slider range - Updated PathsController.js to filter character paths by selected season and slider range - Both controllers now dynamically use SeasonController.getCurrentSeason() instead of hardcoded season values - Ensures markers and paths refresh automatically when season or episode range changes - Prepares app for multiple seasons and dynamic episode counts
…o trigger event when selection changing
…o trigger event when selection changing
…ipt in seasonController.js file
… episode range selectedin slider
… more organized code
…can load at correct time
Contributor
Author
|
hello @algernhon, I really love this creation of yours, I hope you can find some time to review or even merge my request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the previously monolithic main.js into smaller, responsibility-based controllers while preserving the ability to run the project locally via index.html (no server or build step required).
It also introduces a season selector, allowing users to choose which season’s paths and markers are displayed on the map. Changing the season fully resets and reloads all relevant data to ensure consistency.
Key Changes
Application Architecture Refactor
Data Structure Improvements
Season Selector
Why Separate Responsibilities?
Work to do
- paths
- markers
- characters