-
Notifications
You must be signed in to change notification settings - Fork 0
Get project ready for publish with workflow and linting updates #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prepares the project for publication by adding CI/CD workflows, updating dependencies, and applying comprehensive linting/formatting improvements across the codebase.
- Adds GitHub Actions workflows for automated linting, type checking, and code formatting verification
- Updates multiple dependencies to their latest versions (astro-swiper, vite, @tailwindcss/forms)
- Applies consistent code formatting: lowercase hex colors, self-closing tags, proper spacing in CSS, and removal of unused variables/imports
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/main.yaml |
Adds CI workflow with lint/type-check and formatting verification jobs |
package.json |
Updates dependency versions for astro-swiper (^1.4.0), vite (^7.3.0), and @tailwindcss/forms (^0.5.11) |
pnpm-lock.yaml |
Updates lock file to reflect new dependency versions including @swc/helpers and zod-to-json-schema |
readme.md |
Simplifies documentation by removing redundant installation section and deployment notes |
src/layouts/components/CategoryMosaic.astro |
Removes unused index parameter and lastDirection variable |
src/layouts/components/ThemeSwitcher.astro |
Applies extensive formatting: self-closing tags, lowercase hex colors, proper CSS spacing, quote consistency |
src/layouts/partials/Footer.astro |
Removes all unused imports (Logo, Social, config, menu, social, textConverter utilities) |
src/layouts/partials/Testimonial.astro |
Replaces external type import with local SwiperOptions interface definition |
src/layouts/shortcodes/Youtube.tsx |
Enhances ts-ignore comment with explanation about dynamic custom element import |
src/pages/index.astro |
Removes unused banner variable from destructuring |
src/styles/generated-theme.css |
Normalizes hex color values to lowercase for consistency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| interface SwiperOptions { | ||
| spaceBetween?: number; | ||
| loop?: boolean; | ||
| autoplay?: { | ||
| delay: number; | ||
| disableOnInteraction: boolean; | ||
| }; | ||
| pagination?: { | ||
| el: string; | ||
| type: "bullets" | "fraction" | "progressbar" | "custom"; | ||
| clickable: boolean; | ||
| dynamicBullets: boolean; | ||
| }; | ||
| breakpoints?: Record< | ||
| number, | ||
| { | ||
| slidesPerView: number; | ||
| } | ||
| >; | ||
| } | ||
Copilot
AI
Dec 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the type import with a locally defined interface reduces type safety and maintainability. The local SwiperOptions interface may drift from the actual swiper/types definition and doesn't include all available options. Consider keeping the type import from swiper/types or creating a shared type definition file if the import is causing build issues.
| interface SwiperOptions { | |
| spaceBetween?: number; | |
| loop?: boolean; | |
| autoplay?: { | |
| delay: number; | |
| disableOnInteraction: boolean; | |
| }; | |
| pagination?: { | |
| el: string; | |
| type: "bullets" | "fraction" | "progressbar" | "custom"; | |
| clickable: boolean; | |
| dynamicBullets: boolean; | |
| }; | |
| breakpoints?: Record< | |
| number, | |
| { | |
| slidesPerView: number; | |
| } | |
| >; | |
| } | |
| import type { SwiperOptions } from "swiper/types"; |
.github/workflows/main.yaml
Outdated
| run: | | ||
| pnpm format | ||
| if [[ -n $(git status --porcelain) ]]; then | ||
| echo "Code is not properly formatted." | ||
| echo "Please run 'pnpm format' locally and commit the changes." | ||
| git diff --exit-code | ||
| exit 1 | ||
| else | ||
| echo "Code is properly formatted." | ||
| fi |
Copilot
AI
Dec 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting check job runs "pnpm format" which modifies files, then checks if anything changed. This means the check is actually formatting the code rather than verifying it's already formatted. Consider using a format check command (like "prettier --check") instead of running the formatter and checking for changes, as this is more efficient and clearer in intent.
| run: | | |
| pnpm format | |
| if [[ -n $(git status --porcelain) ]]; then | |
| echo "Code is not properly formatted." | |
| echo "Please run 'pnpm format' locally and commit the changes." | |
| git diff --exit-code | |
| exit 1 | |
| else | |
| echo "Code is properly formatted." | |
| fi | |
| run: pnpm format:check |
541ef0f to
6ef8cc1
Compare
6ef8cc1 to
74ffb2b
Compare
74ffb2b to
95e0b53
Compare
No description provided.