Open
Conversation
Added code for random name generator function
| """ | ||
|
|
||
| #list comprehension to convert input string into list of names | ||
| name_list = [name.strip() for name in name_string.split(',')] |
There was a problem hiding this comment.
You could implement set() into your list of names to remove duplicates.
AmarildoGuga
left a comment
AmarildoGuga
left a comment
There was a problem hiding this comment.
Outstanding job Roman. We have a lot to learn from you with your fantastic solution to the problem and coding standards. Your code is very well documented and easy to follow. I like how you have implemented a lot of fail safes to make sure the users input do not contain any odd/special characters.
Lovely piece of work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code for random name generator function