Amarildo Guga - Random Name Generator#30
Open
AmarildoGuga wants to merge 4 commits intoalexnaylor99:mainfrom
Open
Amarildo Guga - Random Name Generator#30AmarildoGuga wants to merge 4 commits intoalexnaylor99:mainfrom
AmarildoGuga wants to merge 4 commits intoalexnaylor99:mainfrom
Conversation
Pova
reviewed
Apr 25, 2023
|
|
||
| def Number(name_list_final): | ||
| """ | ||
| This function will ask the user the number of names they want from the list |
There was a problem hiding this comment.
Small inconsistency with documentation: "The function..." on line 5 vs "This function..." on line 18. Pick one convention and stick to it
Pova
reviewed
Apr 25, 2023
| while len(name_list_final) < 2: | ||
| name_list = input("Please input more than one name please. ") | ||
| name_list_final = list(set(name_list.split())) | ||
|
|
There was a problem hiding this comment.
Could add a check for invalid names i.e. John7 or John% here
Pova
reviewed
Apr 25, 2023
| def Names(): | ||
| """ | ||
| The function asks the user for names, checks them, and returns them. | ||
| """ |
There was a problem hiding this comment.
Could provide extra information on output format in the function documentation here (also for functions below)
Pova
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Excellent job fulfilling the project specifications.
Positives:
- No major bugs or errors with the code
- Maintains general pythonic code structure
- Good use of modularity to split up the script
Things to improve:
- Be more consistent with function documentation and include more detail into input/output data types
- Consider edge cases you may need to check for (i.e. invalid names)
- Consider adding commenting throughout your code to explain the logical flow of the script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.