Ruy Zambrano Random-Name-Generator Submission#25
Open
Ruyzambrano wants to merge 17 commits intoalexnaylor99:mainfrom
Open
Ruy Zambrano Random-Name-Generator Submission#25Ruyzambrano wants to merge 17 commits intoalexnaylor99:mainfrom
Ruyzambrano wants to merge 17 commits intoalexnaylor99:mainfrom
Conversation
… number of names from the list. I also added error handling.
Final Changes
HineshX
reviewed
Apr 25, 2023
|
|
||
| # Check if the user has input names. | ||
| if names == '': | ||
| print('You must enter at lease 1 name. Try again.') |
|
|
||
| # Return entire list of names if there aren't enough. | ||
| else: | ||
| shortlist = list_names |
There was a problem hiding this comment.
if number they choose exceeds number of names given, a 'random' number of names are not given, maybe implement code that generates all the names but still randomized?
|
|
||
| # Generate the shortlist. | ||
| if len(list_names) > num_names: | ||
| shortlist = random_name_generator(list_names, num_names) |
There was a problem hiding this comment.
instead of creating a function and then calling it here, would it not be more concise to just implement the random.sample() code here? e.g shortlist = random.sample(list_names, num_names)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.