Solution for uncreative parents#17
Open
ctorrington wants to merge 6 commits intoalexnaylor99:mainfrom
Open
Conversation
HenryXanderTalent
left a comment
There was a problem hiding this comment.
Positive:
-
Good use of the class feature.
-
Good use of regular expressions.
-
Good use of comments and doc strings, all methods are easy to distinguish.
-
Good consistency with naming for methods and variables.
-
Good use of lambdas.
-
Well structured with consistent spacing and indentation.
Recommendations:
-
Nice story at the beginning but doesn't explain clearly what the app does or how to use it. I noticed it does instruct the user once started so I guess its not such an issue.
-
No readme.
-
App fails if you enter a non digit and has no error handling. Possibly use exception handling and a system call import to restart the app or add another validation method for this.
Overall:
- Well formatted with advance python techniques and does the job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readme fixes + code solution :)
for @alexnaylor99 & everyone to critique.