Open
Conversation
Robrowno
reviewed
Apr 12, 2023
Robrowno
left a comment
Robrowno
left a comment
There was a problem hiding this comment.
The code is well-formatted, and explained in detail with clear and concise comments.
This was a really interesting way of solving the challenge as well.
I've got nothing to critique on the code itself, just that perhaps a README.md file would go well with this to detail the task and any bugs/issues encountered along the way.
Great work mate!
|
Code i written and formatted in detail with easy to read. I would suggest adding docstrings for the functions to describe the purpose of each function and their expected input and output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.