Conversation
| @@ -0,0 +1,43 @@ | |||
| import random | |||
|
|
|||
| # Function to randomly select a specified number of names from a list of names | |||
There was a problem hiding this comment.
Good use of comments: The code contains useful comments that explain what each part of the code does. This makes it easier for others to understand and maintain the code.
| import random | ||
|
|
||
| # Function to randomly select a specified number of names from a list of names | ||
| def random_name_selector(names, num_selections): |
There was a problem hiding this comment.
Good use of functions: The code defines a function random_name_selector to perform the core task of randomly selecting names. This is good programming practice as it makes the code more modular and reusable.
There was a problem hiding this comment.
The code uses consistent style throughout, including indentation, spacing, and variable naming. This makes the code easy to read and understand.
|
Great use of try/catch to handle errors. One thing to consider and it's more so about the concept rather than coding practice, you wouldn't want to return the full list back to the user as the purpose is to narrow down the provided list by returning a randomly selected subset of the provided list. To do this, it could be as simple as changing your condition to
instead of
Note the operator for the second condition. |
| return selected_names | ||
| else: | ||
| # Return an error message if the number of selections is invalid | ||
| return "Invalid input: number of selections should be between 1 and the length of the shortlist." |
There was a problem hiding this comment.
Use f-strings for error message: The code currently returns an error message as a string. It would be more Pythonic to use f-strings to format the error message, like so: return f"Invalid input: number of selections should be between 1 and {len(names)}.".
3 participants
No description provided.