Completed Random Name Generator Mini Project - Pending Review#12
Open
mjoseph26 wants to merge 3 commits intoalexnaylor99:mainfrom
Open
Completed Random Name Generator Mini Project - Pending Review#12mjoseph26 wants to merge 3 commits intoalexnaylor99:mainfrom
mjoseph26 wants to merge 3 commits intoalexnaylor99:mainfrom
Conversation
|
If you want to check that the user did not enter the same name twice, you should be checking for cases as well (i.e. Mathew and mathew will bypass your current check). Apart from that, good job with the comments and with using functions! |
Author
|
Added check for cases for user input and prevented duplicate names. |
| @@ -0,0 +1,47 @@ | |||
| import random; | |||
There was a problem hiding this comment.
Don't forget to update README file to give other developers a good brief of what this project does
| @@ -0,0 +1,47 @@ | |||
| import random; | |||
| names = [] | |||
| #A user-defined function that collects names from the user to create a shortlist and verifies user input | |||
There was a problem hiding this comment.
Great use of comments to give information about the code
Modified variable names according to Python convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have completed the python code for the random name generator mini project and would like to have my code peer reviewed.