Completed Project. Pending: Review#11
Open
MarioTawfelis wants to merge 1 commit intoalexnaylor99:mainfrom
Open
Completed Project. Pending: Review#11MarioTawfelis wants to merge 1 commit intoalexnaylor99:mainfrom
MarioTawfelis wants to merge 1 commit intoalexnaylor99:mainfrom
Conversation
mjoseph26
reviewed
Apr 5, 2023
mjoseph26
left a comment
mjoseph26
left a comment
There was a problem hiding this comment.
Overall the code looks good, good use of comments as well to improve the readability of your code. You could check if a name has been entered already to prevent the user from entering duplicate names.
|
Code looks easy to read and works fine following all the requirement. It is well commented as well to follow up each function and methods involved. I would suggest adding error handling to ensure the code runs smoothly to prevent throwing error with wrong user prompts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.