Open
Conversation
T-meji
reviewed
Aug 29, 2023
Collaborator
T-meji
left a comment
T-meji
left a comment
There was a problem hiding this comment.
Really great work! I like that everything is clear and well documented, as well as how you compartmentalised different aspects of your code, e.g., a separate webhooks file, a readme instruction manual for the app, etc.
Collaborator
There was a problem hiding this comment.
Great:
- Notation/documentation
- Clear
- Concise
- Unpacked
- Kept to coding standards
- Zen code
- Kept API Key hidden (good for security reasons)
Areas for Improvement:
- Add explanatory comments to lines 1, 12 and 78?
Collaborator
There was a problem hiding this comment.
Great:
- Hid Webhooks key (good for security reasons)
- Clear and concise
- Zen and unpacked (kept to the one line rule)
- Comments explain the corresponding code
- Complex but not complicated
- Met all brief objectives
Areas for Improvement:
- Could added 'importing packages' comment on the first line?
Collaborator
There was a problem hiding this comment.
Great readme! A step-by-step guide for the stakeholders to ensure the application runs smoothly and that they can receive the IFTTT alerts. Very helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added real-time stock monitoring features and IFTTT alerts to the project. Check it out when you get a chance!
What's I've done:
Looking forward to your thoughts!