Open
Conversation
|
|
||
|
|
||
|
|
||
| PRICE_DROP_THRESHOLD = 0.25 #THRESHOLD FOR PRICE DROP |
There was a problem hiding this comment.
Very good use of variables to avoid magic numbers- falls within good coding standards
|
|
||
|
|
||
|
|
||
| #FUNCTION THAT RETURNS LATEST PRICE STOCKS |
There was a problem hiding this comment.
Good use of comments to clarify code
|
|
||
|
|
||
|
|
||
| time.sleep(300) #CHECKING PRICE AGAIN EVERY FIVE MINS |
There was a problem hiding this comment.
Frequency of every 5 mins aligns with the rate at which the source updates its stock prices, and so could have explained that in separate documentation
|
|
||
| time.sleep(300) #CHECKING PRICE AGAIN EVERY FIVE MINS | ||
|
|
||
| except Exception as e: |
There was a problem hiding this comment.
Could have used exceptions more to avoid disruptions that come from all the inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.