Skip to content

Python file for API-Stock-Signalling app#12

Open
virginiacodes wants to merge 5 commits intoalexnaylor99:mainfrom
virginiacodes:main
Open

Python file for API-Stock-Signalling app#12
virginiacodes wants to merge 5 commits intoalexnaylor99:mainfrom
virginiacodes:main

Conversation

@virginiacodes
Copy link

No description provided.

The stock data are in dollars, so the £0.25 needed to be changed to $0.30 to reflect that.
@sdirie93
Copy link

sdirie93 commented Oct 16, 2023

Good use of snake case when naming variables, also variable names make sense.
Very good use of comments, which are easily understood and good practice.
Followed the client’s specification of monitoring stock prices, sending a notifications however you have put your price change as £0.30 and not £0.25. Also followed the client's ask of getting a 7-day average of the stock prices.
Overall, very good and well done 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants