Skip to content

Guard pre-redisplay hook to prevent multi-frame feedback loop #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kovan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard pre-redisplay hook to prevent multi-frame feedback loop #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions dirvish.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,10 +1127,13 @@ Optionally, use CURSOR as the enabled cursor type."
(dirvish-use-header-line t))))))

(defun dirvish-pre-redisplay-h (window)
"Record root WINDOW and redisplay sessions in selected frame."
(setq dirvish--selected-window (frame-selected-window))
(when-let* ((dv (dirvish-curr))) (setf (dv-root-window dv) window))
(dirvish--redisplay))
"Record root WINDOW and redisplay sessions in selected frame.
Only act when WINDOW is the selected window in its frame to prevent
a redisplay feedback loop when dirvish is open in multiple frames."
(when (eq (frame-selected-window) window)
(setq dirvish--selected-window window)
(when-let* ((dv (dirvish-curr))) (setf (dv-root-window dv) window))
(dirvish--redisplay)))

(defun dirvish-post-command-h ()
"Reset cursor shape and position and update preview."
Expand Down