Reorganize adding handlers to allow for reuse#116
Open
realumhelp wants to merge 1 commit intoalexgolec:masterfrom
Open
Reorganize adding handlers to allow for reuse#116realumhelp wants to merge 1 commit intoalexgolec:masterfrom
realumhelp wants to merge 1 commit intoalexgolec:masterfrom
Conversation
…call read_stream again if the stream fails and prevent them from erroneously adding an extra handler.
alexgolec
force-pushed
the
master
branch
5 times, most recently
from
ae0c326 to
a3b7b3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
Moved add_nasdaq_book_handler out of read_stream() to allow users to call read_stream again if the stream fails and prevent them from erroneously adding an extra handler