Improve test coverage for internal package#6
Merged
alexfedosov merged 2 commits intomainfrom Apr 11, 2025
Merged
Conversation
Owner
Author
|
@OpenHands run go fmt, we use tabs, not spaces for indentation |
|
I'm on it! @alexfedosov can track my progress at all-hands.dev |
|
I successfully addressed the PR comment that requested running Here's a summary of what I did:
The formatting changes were applied to three test files:
These files now properly use tabs for indentation as per the project's coding standards. The request has been addressed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the test coverage of the internal package from 80.9% to 82.7% by adding the following tests:
Added tests for the
sanitizePresetNamefunction ininternal/app_test.go:Added tests for the
archivePresetBundlefunction ininternal/fileutils_test.go:Added tests for the
writePresetFilefunction ininternal/fileutils_test.go:Added tests for the
writeAudioFileSlicesfunction ininternal/audioutils_test.go:All tests are passing.