Adding Custom Post Type Capabilities by default#1
Open
mnelson4 wants to merge 1 commit intoalex11:masterfrom
Open
Adding Custom Post Type Capabilities by default#1mnelson4 wants to merge 1 commit intoalex11:masterfrom
mnelson4 wants to merge 1 commit intoalex11:masterfrom
Conversation
… admins to have access, however, to these capabilities, admins need to be able to edit admin roles within this plugin, so I define URE_SHOW_ADMIN_ROLE. Having admins able to edit admin caps makes sense, especially because we are hiding the capability which allows them to view this page anyways. Therefore, using this plugin, an admin can never remove their ability to administrate roles, so its perfectly safe for them to edit admin roles, I think
Owner
|
I'll be watching this. Thanks for your commit. |
|
You also need to update the plugin to BP 1.7 Sorry, I can't open a new topic. |
Collaborator
|
i tried to update buddypress but the plugin "BP Group Documents" (http://buddypress.org/support/topic/where-is-the-bp-group-documents-plugin/) doesn't work with BP 1.8. The developer of this plugin has stopped its work :( This blocks the update because the plugin is essential for many groups. I try to find another solution and then i can test this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom post type is registered, and it has custom capabilities, those capabilties get added to the caps that can be edited within this plugin by default.
Also, in order for that to work properly, admins need to be able to edit admin capabilities (otherwise they can be missing capabilities in regards to custom post types)