Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds PEP 561-compliant type stubs to enable type checking for the toons Python extension module, fixing issue #2 where type checkers like ty could not resolve module attributes. The changes include creating a .pyi stub file, configuring maturin to include it in distributions, bumping the package version, and updating the ruff pre-commit hook.
Changes:
- Added
toons.pyitype stub file with complete function signatures forload,loads,dump, anddumps - Configured maturin to include the type stub in package distributions
- Bumped version from 0.5.0 to 0.5.1
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| toons.pyi | New type stub file providing type hints for all public API functions with correct signatures matching the Rust implementation |
| pyproject.toml | Added include = ["toons.pyi"] to maturin configuration to ensure type stubs are distributed with the package |
| Cargo.toml | Version bumped from 0.5.0 to 0.5.1 |
| Cargo.lock | Lock file updated to reflect version 0.5.1 |
| .pre-commit-config.yaml | Updated ruff pre-commit hook from v0.14.10 to v0.15.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2