Skip to content

Conversation

@RingoftheKing
Copy link

@RingoftheKing RingoftheKing commented Jan 15, 2025

Video was not scaling on x-axis correctly, small fix to be more robust to videos of different dimensions

@alenzenx
Copy link
Owner

alenzenx commented Feb 6, 2025

Thank you for your contribution to open-source! I plan to make these improvements available here so that anyone who needs them can use them freely. Since the modifications involve changes to the video aspect ratio, merging the branch would require retraining the model and reevaluating its performance, which might lead to discrepancies compared to the results presented in the paper. Therefore, merging the branch may not be feasible at the moment. However, the improvements will still be accessible here for those who need them. If you have a better solution, feel free to propose it!

@alenzenx
Copy link
Owner

alenzenx commented Feb 6, 2025

感謝你對於開源貢獻一份心力!這些改進我打算放在這裡讓有需要的人自行取用,因為有寫修改有動到影片比例,合併分支的話需要重新訓練模型與評估,可能會與論文展示的績效有差異,所以目前可能沒辦法合併分支,但是還是可以放在這裡讓有需要的人取用,如果有更好的解決方案也歡迎提出!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants