refactor!: modernize architecture, resolve logging conflicts and standardize i18n#85
Open
void0x14 wants to merge 6 commits intoaleiepure:mainfrom
Open
refactor!: modernize architecture, resolve logging conflicts and standardize i18n#85void0x14 wants to merge 6 commits intoaleiepure:mainfrom
void0x14 wants to merge 6 commits intoaleiepure:mainfrom
Conversation
Updated README to reflect active maintenance status, enhanced features, and corrected links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces critical structural improvements to resolve namespace conflicts and standardize the codebase for future development. The primary focus is on resolving library shadowing issues and establishing English as the primary development language.
Detailed Changes
1. Fix: Logging Namespace Conflict
The local directory
src/loggingwas shadowing the standard Pythonlogginglibrary. This causedImportErrorexceptions when external dependencies attempted to access the standard library'sLogRecordclass.app_logging.2. Codebase Standardization
To facilitate broader contribution, the entire codebase (comments, variable names, and docstrings) has been refactored to English. This eliminates language barriers for new contributors and aligns with open-source best practices.
3. Documentation Improvements
Added
docs/DEVELOPER_GUIDE.mdwhich documents:ContentGridView(Widget recycling patterns).4. Security & Persistence
LocalProvider.pyto ensure all SQL queries utilize parameterized inputs, enhancing security against injection attacks.5. Performance: Memory Leak Prevention
Testing
org.gnome.Platformruntime version 49.Note to maintainers: This is my first contribution to the project (and my first ever OSS PR! 🎉). I've done my best to align with the project's architecture, but I'm open to any feedback or style corrections needed to get this merged.
Waiting for your review.